Reworking locations #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnasbr
commented
Apr 26, 2024
scripts/time-filter-proto.js
Outdated
Comment on lines
47
to
52
| const location = __ENV.LOCATION || 'UK/London' | ||
| const country = location.slice(0, 2).toLowerCase() | ||
| const countryCoords = getProtoCountryCoordinates(location) | ||
|
|
||
| const query = __ENV.QUERY || `api/v2/${countryCode(country)}/time-filter/fast/${transportation}` |
There was a problem hiding this comment.
the location.slice is used to get the iso2 country-code from the location, it's needed to construct the proto request url. I could make the user specify the iso2 code manually, but this might be simpler
There was a problem hiding this comment.
tho it could break if the user decides to add a new location and doesn't follow the same naming pattern. I have a warning on this in readme
arnasbr
force-pushed
the
update-country-names
branch
from
0ff80e0
to
ca5ebb5
Compare
|
https://simplemaps.com/data/world-cities data was taken from here (the The file by default is a csv, I turned it into json manually. I can turn it back to csv if that would be more convenient |
arnasbr
force-pushed
the
update-country-names
branch
from
ca5ebb5
to
c6386ec
Compare
danielnaumau
approved these changes
May 8, 2024
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed this
"us_hi": { "lat": 21.3098845, "lng": -157.8581401 }location from proto locations, as it just points to the ocean. Let me know if this is actually a useful location.